Add captureMethod to createPaymentIntent #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And always provide one.
Attempt to fix build errors like: > Could not configure Apple Service authentication: 2FA session saved > in Bitrise Developer Connection is expired, was valid until 2023-03-12 > 21:32:16 +0000 UTC (exit code: 1) https://app.bitrise.io/build/0565de0f-1eef-4d6c-a660-b6c5c709b6f4
It's not used yet, but this brings the example-app up-to-date with our dev-app.
Match our dev app and other example apps.
Our example-app is pinned to the currently released version of the RN SDK. So, we can't make these changes yet.
billfinn-stripe
requested review from
bric-stripe,
rv-stripe and
chr-stripe
as code owners
4 tasks
bric-stripe
approved these changes
Mar 15, 2023
Comment on lines
+465
to
+484
| <List bolded={false} topSpacing={false} title="CAPTURE METHOD"> | ||
| <Picker | ||
| selectedValue={inputValues?.captureMethod} | ||
| style={styles.picker} | ||
| itemStyle={styles.pickerItem} | ||
| testID="select-capture-method-picker" | ||
| onValueChange={(value) => | ||
| setInputValues((state) => ({ ...state, captureMethod: value })) | ||
| } | ||
| > | ||
| {CAPTURE_METHODS.map((a) => ( | ||
| <Picker.Item | ||
| key={a.value} | ||
| label={a.label} | ||
| testID={a.value} | ||
| value={a.value} | ||
| /> | ||
| ))} | ||
| </Picker> | ||
| </List> |
There was a problem hiding this comment.
ignorable consistency nit: the native example apps use a "Automatic capture" switch instead of a picker...but thinking more about this I think I prefer the picker since it clarifies its an enum and just happens to have two options. So maybe my consistency nit should be to update the native example apps 🤷♂️
| @@ -49,7 +49,7 @@ export default function CollectCardPaymentScreen() { | |||
| }); | |||
| const [testCardNumber, setTestCardNumber] = useState('4242424242424242'); | |||
| const [enableInterac, setEnableInterac] = useState(false); | |||
| const [skipTipping, setSkipTipping] = useState(true); | |||
| const [skipTipping, setSkipTipping] = useState(false); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Build on top of #443 to support
captureMethodfor iOS and Android and in thedev and example apps.
Tested example-app using yalc:
Testing
Documentation
Select one: