Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error handle when call initialize api. #463

Closed
wants to merge 1 commit into from
Closed

Add error handle when call initialize api. #463

wants to merge 1 commit into from

Conversation

chenzesam
Copy link
Contributor

Summary

Add error handle when calling initialize API on Android.

Motivation

When I call this interface when the Bluetooth permission is not granted, it will crash my APP.

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@chenzesam
Copy link
Contributor Author

@nazli-stripe help to see it, thx~

@nazli-stripe nazli-stripe mentioned this pull request Jul 7, 2023
Merged
4 tasks
@nazli-stripe
Copy link
Collaborator

@chenzesam thanks for the submission, closing in favor of #491 which includes some Bitrise fixes that were preventing this PR from being merges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chr-stripe chr-stripe chr-stripe approved these changes

@billfinn-stripe billfinn-stripe Awaiting requested review from billfinn-stripe billfinn-stripe is a code owner

@bric-stripe bric-stripe Awaiting requested review from bric-stripe bric-stripe is a code owner

@rv-stripe rv-stripe Awaiting requested review from rv-stripe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenzesam @nazli-stripe @chr-stripe