Cache token provider callback between re-renders. #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-stripe
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe and
rv-stripe
as code owners
chr-stripe
force-pushed
the
chr/memoize-tokenprovider
branch
from
927c0d9 to
baf8771
Compare
| if (!api) { | ||
| console.log('hi hi hi'); |
nazli-stripe
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevent instantiating a new fetchTokenProvider function on each render pass.
Motivation
Prevents the dev/example apps from reinitializing the Terminal SDK
more than once when unnecessary.
Testing
Documentation
Select one: