Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow customization of Local Network message for Expo projects on iOS #585

Merged

Conversation

ts-candide
Copy link
Contributor

@ts-candide ts-candide commented Dec 7, 2023

Summary

Allow customisation of the pop-up message that appears when an Expo-based app attempts to connect to an Internet card reader for the first time, on iOS.

Motivation

On iOS 14+, the first time that the app attempts to connect to an Internet card reader (such as the WisePOS), a message appears asking the user to allow access to the Local Network. The description that appears can be customised by setting the NSLocalNetworkUsageDescription property list key. This change allows the description to be customised in an Expo app by setting the localNetworkUsagePermission property in the relevant plugin config.

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

If/when this is merged and released, this will require changes to the setup integration docs.

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2023

CLA assistant check
All committers have signed the CLA.

@nazli-stripe nazli-stripe merged commit a6d986f into stripe:main Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants