Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added correct example app name #587

Merged

Conversation

thePianoKid
Copy link
Contributor

@thePianoKid thePianoKid commented Dec 10, 2023

Summary

CONTRIBUTING.md had multiple references to this repo's example project. In CONTRIBUTING.md, the example project was supposed to belong in the /example directory, when it was actually in the /example-app directory. The /example directory does not exist.

Motivation

This is a tiny correction, but it adds a bit of unnecessary friction to the onboarding process :)

Testing

N/A - all changes were made to docs. None of the functionality was changed.

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2023

CLA assistant check
All committers have signed the CLA.

@thePianoKid
Copy link
Contributor Author

thePianoKid commented Dec 10, 2023

👇 Bitrise is failing, but my change doesn't effect the functionality... am I doing something wrong?

@nazli-stripe
Copy link
Collaborator

@thePianoKid thanks for the PR! Bitrise requires admin approval to run the tests, which I just approved. It should pass as this is just a ReadMe change, after which I'll merge the PR!

@nazli-stripe nazli-stripe merged commit 70d6a5f into stripe:main Dec 13, 2023
2 checks passed
@thePianoKid thePianoKid deleted the thePianoKid/update-contributing-docs branch December 14, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants