Support Interac Refund #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianlin-bbpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
Comment on lines
659
to
663
| if (chargeId.isNullOrBlank() && paymentIntentId.isNullOrBlank()) { | ||
| throw TerminalException( | ||
| TerminalException.TerminalErrorCode.INVALID_REQUIRED_PARAMETER, | ||
| "You must provide a refund Id." | ||
| ) |
There was a problem hiding this comment.
Can we also throw an error when both charge ID and PaymentIntent ids are set, we should only accept "one of", seems like the case we're using the chargeID here when a user provides both
| @@ -652,8 +653,14 @@ class StripeTerminalReactNativeModule(reactContext: ReactApplicationContext) : | |||
| @Suppress("unused") | |||
| fun collectRefundPaymentMethod(params: ReadableMap, promise: Promise) = | |||
| withExceptionResolver(promise) { | |||
| val chargeId = requireParam(params.getString("chargeId")) { | |||
| "You must provide a chargeId" | |||
| val chargeId = params.getString("chargeId") | |||
There was a problem hiding this comment.
can we add these changes for iOS as well?
nazli-stripe
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support Interac Refund.
Motivation
Support Interac Refund.
Testing
Documentation
Select one: