Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds addListener and removeListeners react methods to android module #636

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Adds addListener and removeListeners react methods to android module #636

merged 1 commit into from
Mar 12, 2024

Conversation

SudoPlz
Copy link
Contributor

@SudoPlz SudoPlz commented Mar 11, 2024

Summary

Fixes #635

Testing

  • [✅ ] I tested this manually
  • [ ❌ ] I added automated tests

Documentation

Select one:

  • [❌ ] I have added relevant documentation for my changes.
  • [✅ ] This PR does not result in any developer-facing changes.

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SudoPlz SudoPlz closed this Mar 11, 2024
@SudoPlz SudoPlz reopened this Mar 11, 2024
@nazli-stripe nazli-stripe merged commit 493f397 into stripe:main Mar 12, 2024
2 checks passed
@SudoPlz
Copy link
Contributor Author

SudoPlz commented Mar 13, 2024

Hey there, thank you @nazli-stripe. Any idea what version that will be released with?

@SudoPlz SudoPlz deleted the patch-1 branch March 13, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazli-stripe nazli-stripe nazli-stripe approved these changes

@billfinn-stripe billfinn-stripe Awaiting requested review from billfinn-stripe billfinn-stripe is a code owner

@bric-stripe bric-stripe Awaiting requested review from bric-stripe bric-stripe is a code owner

@ugochukwu-stripe ugochukwu-stripe Awaiting requested review from ugochukwu-stripe ugochukwu-stripe is a code owner

@ebarrenechea-stripe ebarrenechea-stripe Awaiting requested review from ebarrenechea-stripe ebarrenechea-stripe is a code owner

@mshafrir-stripe mshafrir-stripe Awaiting requested review from mshafrir-stripe mshafrir-stripe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new NativeEventEmitter() was called with a non-null argument without the required addListener method.
3 participants
@SudoPlz @CLAassistant @nazli-stripe