Add TTP auto-reconnect support #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazli-stripe
requested review from
billfinn-stripe,
bric-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
bric-stripe
approved these changes
Mar 18, 2024
Comment on lines
+315
to
+324
| let autoReconnectOnUnexpectedDisconnect = params["autoReconnectOnUnexpectedDisconnect"] as? Bool ?? false | ||
|
|
||
| let connectionConfig: LocalMobileConnectionConfiguration | ||
| do { | ||
| connectionConfig = try LocalMobileConnectionConfigurationBuilder(locationId: locationId ?? selectedReader.locationId ?? "") | ||
| .setMerchantDisplayName(merchantDisplayName ?? nil) | ||
| .setOnBehalfOf(onBehalfOf ?? nil) | ||
| .setTosAcceptancePermitted(tosAcceptancePermitted) | ||
| .setAutoReconnectOnUnexpectedDisconnect(autoReconnectOnUnexpectedDisconnect) | ||
| .setAutoReconnectionDelegate(autoReconnectOnUnexpectedDisconnect ? self : nil) |
There was a problem hiding this comment.
not for this PR but we should probably setup the Swift code to use a connectReader extension similar to Android's so they're more closely matched 🤔 just noticed this difference (very low pri though 🤷♂️)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for TTP auto-reconnection
Motivation
3.4.0 update
Testing
Documentation
Select one: