sPOS offline mode support #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazli-stripe
force-pushed
the
nazli/spos-offline
branch
2 times, most recently
from
6641c1a to
b66a50e
Compare
nazli-stripe
force-pushed
the
nazli/spos-offline
branch
from
b66a50e to
58832b5
Compare
nazli-stripe
requested review from
billfinn-stripe,
bric-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
| private fun mapFromAmountDetails(amountDetails: AmountDetails?): ReadableMap? = | ||
| amountDetails?.let { | ||
| nativeMapOf { | ||
| putMap("tip", nativeMapOf { putInt("amount", amountDetails.tip?.amount?.toInt() ?: 0) }) |
There was a problem hiding this comment.
Nit: we may want putIntOrNull here because "0" is different from "tip was skipped".
| putString("tsi", receiptDetails?.tsi) | ||
| putString("tvr", receiptDetails?.tvr) | ||
| putString("transactionStatusInformation", receiptDetails?.tsi) | ||
| putString("terminalVerificationResult", receiptDetails?.tvr) |
There was a problem hiding this comment.
Reminder to add these name changes to a CHANGELOG.
| offlinePaymentStatus.sdk.offlinePaymentAmountsByCurrency[ | ||
| key | ||
| ] | ||
| offlinePaymentStatus.reader! |
There was a problem hiding this comment.
Shouldn't this be sdk?
| @@ -145,6 +145,8 @@ internal fun mapFromDeviceType(type: DeviceType): String { | |||
| DeviceType.WISEPAD_3S -> "wisePad3s" | |||
| DeviceType.WISEPOS_E_DEVKIT -> "wisePosEDevkit" | |||
| DeviceType.STRIPE_S700_DEVKIT -> "stripeS700Devkit" | |||
| DeviceType.STRIPE_S700 -> "stripeS700" | |||
There was a problem hiding this comment.
This case is already covered. Suggest sorting this list alphabetically to make dupes easier to find.
billfinn-stripe
previously approved these changes
Mar 28, 2024
| @@ -165,6 +165,7 @@ export default function CollectCardPaymentScreen() { | |||
| }; | |||
| let paymentIntent: PaymentIntent.Type | undefined; | |||
| let paymentIntentError: StripeError<CommonError> | undefined; | |||
| console.log(deviceType); | |||
There was a problem hiding this comment.
Nit: remove debug log?
billfinn-stripe
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds offline mode support for sPOS readers:
Motivation
Testing
Documentation
Select one: