Timeout for BT discovery scan #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianlin-bbpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
src/types/index.ts
Outdated
| @@ -22,6 +22,7 @@ export type LogLevelIOS = 'none' | 'verbose'; | |||
| export type LogLevelAndroid = 'none' | 'verbose' | 'error' | 'warning'; | |||
|
|
|||
| export type DiscoverReadersParams = { | |||
| timeout: number; | |||
There was a problem hiding this comment.
let's make this an optional param
Suggested change
| timeout: number; | |
| timeout?: number; |
| @@ -170,10 +170,11 @@ class StripeTerminalReactNative: RCTEventEmitter, DiscoveryDelegate, BluetoothRe | |||
| func discoverReaders(params: NSDictionary, resolver resolve: @escaping RCTPromiseResolveBlock, rejecter reject: @escaping RCTPromiseRejectBlock) { | |||
| let simulated = params["simulated"] as? Bool | |||
| let discoveryMethod = params["discoveryMethod"] as? String | |||
|
|
|||
| let timeout = params["timeout"] as? UInt ?? 0 | |||
There was a problem hiding this comment.
@bric-stripe any issues with setting the timeout to 0 by default?
There was a problem hiding this comment.
nope, no concerns. that's the native SDKs default as well 👍
nazli-stripe
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add timeout param for BT discovery scan.
Motivation
To support setting bluetooth discovery scan timeout.
Testing
Documentation
Select one: