Add method of supportsReadersOfType #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianlin-bbpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
ios/StripeTerminalReactNative.swift
Outdated
| resolve(["readerSupportResult": false]) | ||
| break | ||
| } | ||
| print("hhhh") |
Comment on lines
+152
to
+168
| internal fun mapToDeviceType(type: String): DeviceType? { | ||
| return when (type) { | ||
| "chipper1X" -> DeviceType.CHIPPER_1X | ||
| "chipper2X" -> DeviceType.CHIPPER_2X | ||
| "cotsDevice" -> DeviceType.COTS_DEVICE | ||
| "etna" -> DeviceType.ETNA | ||
| "stripeM2" -> DeviceType.STRIPE_M2 | ||
| "stripeS700" -> DeviceType.STRIPE_S700 | ||
| "stripeS700Devkit" -> DeviceType.STRIPE_S700_DEVKIT | ||
| "verifoneP400" -> DeviceType.VERIFONE_P400 | ||
| "wiseCube" -> DeviceType.WISECUBE | ||
| "wisePad3" -> DeviceType.WISEPAD_3 | ||
| "wisePad3s" -> DeviceType.WISEPAD_3S | ||
| "wisePosE" -> DeviceType.WISEPOS_E | ||
| "wisePosEDevkit" -> DeviceType.WISEPOS_E_DEVKIT | ||
| else -> null | ||
| } |
There was a problem hiding this comment.
How do we keep this list up to date; i.e when there is a new device type on the android sdk, can we have a two way map; i.e also have a mapFromDeviceType if one does not exist already, because an exhaustive when with the android DeviceType enum model would result in a compilation error when there is a new DeviceType enum.
Also do we have tests for the Mappers?
There was a problem hiding this comment.
yes, there has a mapFromDeviceType, I think we need to sync manually when there is a new device type..
bric-stripe
reviewed
May 13, 2024
ios/StripeTerminalReactNative.swift
Outdated
Comment on lines
1147
to
1150
| guard invalidParams == nil else { | ||
| resolve(Errors.createError(code: CommonErrorType.InvalidRequiredParameter, message: "You must provide \(invalidParams!) parameters.")) | ||
| return | ||
| } |
There was a problem hiding this comment.
we should try to avoid using !. Flipping to an if let gets around that:
Suggested change
| guard invalidParams == nil else { | |
| resolve(Errors.createError(code: CommonErrorType.InvalidRequiredParameter, message: "You must provide \(invalidParams!) parameters.")) | |
| return | |
| } | |
| if let invalidParams { | |
| resolve(Errors.createError(code: CommonErrorType.InvalidRequiredParameter, message: "You must provide \(invalidParams) parameters.")) | |
| return | |
| } |
ios/StripeTerminalReactNative.swift
Outdated
| resolve(Errors.createError(code: CommonErrorType.InvalidRequiredParameter, message: "You must provide correct deviceType parameter.")) | ||
| return | ||
| } | ||
| print("supportsReadersOfType") |
There was a problem hiding this comment.
rm the print and a few others below
ios/StripeTerminalReactNative.swift
Outdated
Comment on lines
1156
to
1161
| guard deviceType != nil else { | ||
| resolve(Errors.createError(code: CommonErrorType.InvalidRequiredParameter, message: "You must provide correct deviceType parameter.")) | ||
| return | ||
| } | ||
| print("supportsReadersOfType") | ||
| let result = Terminal.shared.supportsReaders(of: deviceType!, discoveryMethod: Mappers.mapToDiscoveryMethod(discoveryMethod), simulated: simulated) |
There was a problem hiding this comment.
similar to above, would be good to avoid the deviceType! with a simple change to use guard let
Suggested change
| guard deviceType != nil else { | |
| resolve(Errors.createError(code: CommonErrorType.InvalidRequiredParameter, message: "You must provide correct deviceType parameter.")) | |
| return | |
| } | |
| print("supportsReadersOfType") | |
| let result = Terminal.shared.supportsReaders(of: deviceType!, discoveryMethod: Mappers.mapToDiscoveryMethod(discoveryMethod), simulated: simulated) | |
| guard let deviceType else { | |
| resolve(Errors.createError(code: CommonErrorType.InvalidRequiredParameter, message: "You must provide correct deviceType parameter.")) | |
| return | |
| } | |
| let result = Terminal.shared.supportsReaders(of: deviceType, discoveryMethod: Mappers.mapToDiscoveryMethod(discoveryMethod), simulated: simulated) |
nazli-stripe
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add method of supportsReadersOfType
Motivation
Testing
Documentation
Select one: