Rename collect input types. #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianlin-bbpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
zakh-stripe
requested changes
Jun 6, 2024
| @@ -859,14 +859,14 @@ class StripeTerminalReactNativeModule(reactContext: ReactApplicationContext) : | |||
| @ReactMethod | |||
| @Suppress("unused") | |||
| fun collectInputs(params: ReadableMap, promise: Promise) = withExceptionResolver(promise) { | |||
| val collectInputs = requireParam(params.getArray("collectInputs")) { | |||
| val collectInputs = requireParam(params.getArray("inputs")) { | |||
| "You must provide a collectInputs" | |||
nazli-stripe
reviewed
Jun 6, 2024
android/src/main/java/com/stripeterminalreactnative/StripeTerminalReactNativeModule.kt
Outdated
Show resolved
Hide resolved
…inalReactNativeModule.kt
nazli-stripe
approved these changes
Jun 7, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rename collect inputs type names to match JS SDK;
Motivation
The public facing type names for RN SDK is different from the JS SDK. Rename these types for the RN SDK to match that of the JS SDK.
Testing
Documentation
Select one: