Fix incorrect unix time conversion at android layer #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricLin-BBpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
| @@ -446,7 +446,7 @@ internal fun mapFromReaderSoftwareUpdate(update: ReaderSoftwareUpdate?): Writabl | |||
| "estimatedUpdateTime", | |||
| mapFromUpdateTimeEstimate(it.timeEstimate) | |||
| ) | |||
| putString("requiredAt", convertToUnixTimestamp(it.requiredAt.time)) | |||
There was a problem hiding this comment.
is there a reason we are fixing here rather than remove the * 1000 part in https://github.com/stripe/stripe-terminal-react-native/blob/93f3ca0b/android/src/main/java/com/stripeterminalreactnative/Mappers.kt#L439
There was a problem hiding this comment.
After function conversion, the "created" field on PaymentIntents is converted to same time units milliseconds on both Android and iOS except requiredAt. So we only need to fixing here.
nazli-stripe
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix incorrect unix time conversion at Android layer.
Motivation
User reported that The availableUpdate object on the connectedReader object returned by the hook useStripeTerminal is inconsistent between android and iOS (The android's requiredAt is 1000 times bigger than it should be). This PR aims to correct this discrepancy to ensure cross-platform functionality is consistent and accurate.
#718
Testing
Documentation
Select one: