Modify script to allow release from non-main branch #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazli-stripe
requested review from
billfinn-stripe,
bric-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
bric-stripe
reviewed
Jul 16, 2024
scripts/publish.sh
Outdated
| echo "Publish successful!" | ||
| echo "" | ||
|
|
||
| create_github_release |
There was a problem hiding this comment.
intentionally rm'd? and is the --follow-tags not needed?
There was a problem hiding this comment.
nope lost in copy paste, added back
nazli-stripe
added a commit
that referenced
this pull request
Jul 24, 2024
* modify script for non main release * dont release from main * add missing lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Publish script changes to force devs into typing the branch name when releasing and disables releases from the main branch to promote using release branches
Motivation
KTLO
Testing
Documentation
Select one: