Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SDKs to 3.8.0 #775

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Bump SDKs to 3.8.0 #775

merged 3 commits into from
Aug 7, 2024

Conversation

ianlin-bbpos
Copy link
Collaborator

Summary

Bump SDKs to 3.8.0.

Motivation

Upgrade the native SDKs to the latest.

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@bric-stripe
Copy link
Collaborator

we just today shipped an iOS 3.8.1 hotfix, could you update this to include that?

@@ -142,6 +142,8 @@ internal fun mapFromDeviceType(type: DeviceType): String {
DeviceType.STRIPE_M2 -> "stripeM2"
DeviceType.STRIPE_S700 -> "stripeS700"
DeviceType.STRIPE_S700_DEVKIT -> "stripeS700Devkit"
DeviceType.STRIPE_S710 -> "stripeS710"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these not needed for iOS?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but iOS does't support S710 yet by v3.8.0.

@nazli-stripe
Copy link
Collaborator

@ianlin-bbpos this can be a different PR but 3.8.0 has support for Tap to Pay UX configuration. Can we add that as well? https://github.com/stripe/stripe-terminal-android/blob/master/CHANGELOG.md#tap-to-pay-localmobile

@ianlin-bbpos
Copy link
Collaborator Author

@ianlin-bbpos this can be a different PR but 3.8.0 has support for Tap to Pay UX configuration. Can we add that as well? https://github.com/stripe/stripe-terminal-android/blob/master/CHANGELOG.md#tap-to-pay-localmobile

Copy that.

@nazli-stripe nazli-stripe merged commit 28bc763 into main Aug 7, 2024
3 checks passed
@nazli-stripe nazli-stripe deleted the bbpos/bump-sdks-to-3.8.0 branch September 7, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants