Add setLocalMobileUxConfiguration. #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianlin-bbpos
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
chr-stripe
reviewed
Aug 8, 2024
src/types/index.ts
Outdated
Comment on lines
545
to
549
| export type Colors = { | ||
| primary: string; | ||
| success: string; | ||
| error: string; | ||
| }; |
There was a problem hiding this comment.
Do the colors have to be specified as a string? I think it would be nice to have them also be provided as an int natively in case that's how someone is storing it.
If specifying this as an int isn't common in React Native in general, I'm peaceful with leaving this as it is 👍
There was a problem hiding this comment.
I've tried use Int, but got a diff value on native side after transfer, seems like a overflow.
android/src/main/java/com/stripeterminalreactnative/StripeTerminalReactNativeModule.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/stripeterminalreactnative/StripeTerminalReactNativeModule.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/stripeterminalreactnative/StripeTerminalReactNativeModule.kt
Outdated
Show resolved
Hide resolved
chr-stripe
approved these changes
Aug 9, 2024
nazli-stripe
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new feature of LocalMobileUxConfiguration.
Motivation
To support setting LocalMobileUxConfiguration
Testing
Documentation
Select one: