Update collectData response to return as a CollectDataResultType #849
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindy-stripe
requested review from
billfinn-stripe,
bric-stripe,
nazli-stripe,
ugochukwu-stripe,
ebarrenechea-stripe and
mshafrir-stripe
as code owners
nazli-stripe
previously approved these changes
Nov 13, 2024
src/functions.ts
Outdated
| @@ -905,7 +905,9 @@ export async function collectData( | |||
| return Logger.traceSdkMethod(async () => { | |||
| try { | |||
| const response = await StripeTerminalSdk.collectData(params); | |||
| return response; | |||
| return { | |||
| collectedData: response | |||
There was a problem hiding this comment.
CI complain about the missing trailing commas style here.
/bitrise/src/src/functions.ts
909:32 error Insert,prettier/prettier
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Trailing_commas
There was a problem hiding this comment.
thanks! updated
nazli-stripe
approved these changes
Nov 14, 2024
nazli-stripe
pushed a commit
that referenced
this pull request
Nov 14, 2024
* Update collectData response to return as a CollectDataResultType * Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix
Terminal.collectDatato return the collected data in the correctCollectDataResultTypeformat. The previous solution was directly returning the collected data object, when it should be returning it nested inside acollectedDatakey as defined inCollectDataResultType.cc-ing @EricLin-BBpos who worked on the initial PR: #765
Motivation
Internal ticket filed by QA: https://jira.corp.stripe.com/browse/TERMINAL-41707
Testing
Tested manually with the dev-app. Ran
npx react-native run-ios --deviceDocumentation
Select one: