add more test cases

stripe · Oct 10, 2024 · 0ce1109 · 0ce1109
1 parent 66f9f63
commit 0ce1109
Showing 1 changed file with 35 additions and 4 deletions.
diff --git a/test/suite/shellEscape.test.ts b/test/suite/shellEscape.test.ts
@@ -1,3 +1,4 @@
+/* eslint-disable quotes */
 import * as assert from 'assert';
 import * as shellEscape from '../../src/shellEscape';
 import * as sinon from 'sinon';
@@ -18,13 +19,43 @@ suite('shellEscape', () => {
   suite('shellEscape', () => {
     test('non windows case: flag with spaces', () => {
       sandbox.stub(utils, 'getOSType').returns(utils.OSType.macOSarm);
-      const output = shellEscape.shellEscape(['--project-name', 'test | whoami']);
-      assert.strictEqual(output, '--project-name \'test | whoami\'');
+      const output = shellEscape.shellEscape(['--project-name', 'test | whoami']); // test | whoami
+      assert.strictEqual(output, `--project-name 'test | whoami'`); // --project-name 'test | whoami'
+    });
+    test('non windows case: flag with single quote around entire arg', () => {
+      sandbox.stub(utils, 'getOSType').returns(utils.OSType.macOSarm);
+      const output = shellEscape.shellEscape(['--project-name', `'test name'`]); // 'test name'
+      assert.strictEqual(output, `--project-name \\''test name'\\'`); // --project-name \''test name'\'
+    });
+    test('non windows case: flag with double quote', () => {
+      sandbox.stub(utils, 'getOSType').returns(utils.OSType.macOSarm);
+      const output = shellEscape.shellEscape(['--project-name', `test "name"`]); // test "name"
+      assert.strictEqual(output, `--project-name 'test "name"'`); // --project-name 'test "name"'
+    });
+    test('non windows case: flag with lots of quotes', () => {
+      sandbox.stub(utils, 'getOSType').returns(utils.OSType.macOSarm);
+      const output = shellEscape.shellEscape(['--project-name', `'test's "name"'`]); // 'test's "name"'
+      assert.strictEqual(output, `--project-name \\''test'\\''s "name"'\\'`); // --project-name \''test'\''s "name"'\'
     });
     test.only('windows case: flag with space', () => {
       sandbox.stub(utils, 'getOSType').returns(utils.OSType.windows);
-      const output = shellEscape.shellEscape(['--project-name', 'test | whoami']);
-      assert.strictEqual(output, '--project-name \"test | whoami\"');
+      const output = shellEscape.shellEscape(['--project-name', 'test | whoami']); // test | whoami
+      assert.strictEqual(output, `--project-name "test | whoami"`); // --project-name "test | whoami"
+    });
+    test.only('windows case: flag with single quote around entire arg', () => {
+      sandbox.stub(utils, 'getOSType').returns(utils.OSType.windows);
+      const output = shellEscape.shellEscape(['--project-name', `'test name'`]); // 'test name'
+      assert.strictEqual(output, `--project-name "'test name'"`); // --project-name "'test name'"
+    });
+    test.only('windows case: flag with double quote', () => {
+      sandbox.stub(utils, 'getOSType').returns(utils.OSType.windows);
+      const output = shellEscape.shellEscape(['--project-name', `test "name"`]); // test "name"
+      assert.strictEqual(output, `--project-name "test \\"name\\""`); // --project-name "test \"name\""
+    });
+    test.only('windows case: flag with lots of quotes', () => {
+      sandbox.stub(utils, 'getOSType').returns(utils.OSType.windows);
+      const output = shellEscape.shellEscape(['--project-name', `'test's "name"'`]); // 'test's "name"'
+      assert.strictEqual(output, `--project-name "'test's \\"name\\"'"`); // --project-name "'test's \"name\"'"
     });
   });
 });