Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dotnet language server for API Reference support #282

Merged
merged 7 commits into from
Jun 17, 2021

Conversation

gracegoo-stripe
Copy link
Contributor

@gracegoo-stripe gracegoo-stripe commented Jun 17, 2021

Addresses #175

In order to support API hover reference for dotnet projects, we needed semantic understanding of the code the user is writing. The dotnet language server identifies when a user is hovering over a Stripe method and returns hover content back to the extension with the link to the relevant point in the doc.

This PR is a combination of previous PRs + a rebase with master:

Testing

On windows: https://user-images.githubusercontent.com/75757829/122482958-657a1900-cf86-11eb-82a0-315c898f803e.mp4
(My screen capture software on windows only lets you record the active window so we can't actually see the link open)

Copy link
Collaborator

@vcheung-stripe vcheung-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity checked the individual PRs, lgtm

@gracegoo-stripe gracegoo-stripe merged commit b170c15 into master Jun 17, 2021
@gracegoo-stripe gracegoo-stripe deleted the dotnet-server branch June 17, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants