Replacing quickpick selection simulation with stubs rather than using… #467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… sleeps
The sample selection process requires a lot of user inputs, the first 4 of which are quick pick selections. Originally, we kicked off the sample creation then a series of sleeps and a command to select the first item in the quick pick. However, this ends up in race conditions sometimes where we went up getting to the selection command before the quick pick setup is completed or where we end up moving on before the select command is reached. Rather than use timers like this, I updated the test to stub out each call of the quickpick command to return the results we expect. The
onCall
API of stubs allows us to return different results based on the order it's called.Example: https://github.com/stripe/vscode-stripe/runs/4360497244?check_suite_focus=true