Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use task to run listen command #836

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

vcheung-stripe
Copy link
Collaborator

This uses a vscode task to run the stripe listen command, allowing us to leverage the built-in escaping features for the shell input: https://code.visualstudio.com/api/references/vscode-api#ShellQuotedString

Copy link
Contributor

@charliecruzan-stripe charliecruzan-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! i think this means we can delete the shellEscape.ts and shellEscape.test.ts files?

@vcheung-stripe
Copy link
Collaborator Author

Yeah I think so, will do

@bernardoamc-stripe
Copy link

bernardoamc-stripe commented Nov 13, 2024

This seems in line with what I was thinking. 👏 Do we have a way to test this with an interesting input?

@vcheung-stripe
Copy link
Collaborator Author

@bernardoamc-stripe I've tried it out with the examples we've seen and they work insofar as they get quoted as expected.

@vcheung-stripe vcheung-stripe merged commit b4238e0 into stripe:master Nov 14, 2024
4 checks passed
@vcheung-stripe vcheung-stripe deleted the vcheung-project-name branch November 14, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants