Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auth check #837

Merged

Conversation

vcheung-stripe
Copy link
Collaborator

This fixes an issue where the extension always prompts for login when you have a project name set.

To check if you're authenticated, we run stripe config --list and parse the TOML output. The problem is when you set a project name, stripe config --list doesn't return valid TOML, so we don't know that you're authenticated.

This fixes it by explicitly setting stripe config --list --project-name default which prints out the config file verbatim so that it's always valid TOML.

@vcheung-stripe vcheung-stripe merged commit 85f290b into stripe:master Nov 14, 2024
4 checks passed
@vcheung-stripe vcheung-stripe deleted the vcheung-check-authenticated branch November 14, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants