Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: One Click $STRK claim for all protocols #17

Merged
merged 3 commits into from
May 6, 2024
Merged

Feat: One Click $STRK claim for all protocols #17

merged 3 commits into from
May 6, 2024

Conversation

zintarh
Copy link
Contributor

@zintarh zintarh commented Apr 26, 2024 •
edited
Loading

PR Fixes:

  • feat: One Click $STRK claim for all protocols

Resolves #2

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@gitguardian GitGuardian
Copy link

gitguardian bot commented Apr 26, 2024 •
edited
Loading

⚠️ GitGuardian has uncovered 7 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10294468 Triggered Generic High Entropy Secret f5d6ed1 src/app/template.tsx View secret
10294468 Triggered Generic High Entropy Secret a616181 next.config.mjs View secret
10294468 Triggered Generic High Entropy Secret a616181 next.config.mjs View secret
10294468 Triggered Generic High Entropy Secret a616181 src/app/template.tsx View secret
10294468 Triggered Generic High Entropy Secret a616181 next.config.mjs View secret
10294468 Triggered Generic High Entropy Secret a616181 src/app/template.tsx View secret
10294468 Triggered Generic High Entropy Secret f5d6ed1 src/app/template.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@zintarh zintarh changed the title Refactor: Refactor Claim Reward Logic Feat: One Click $STRK claim for all protocols Apr 26, 2024
akiraonstarknet
akiraonstarknet reviewed Apr 26, 2024
View reviewed changes
src/services/apiService.ts Outdated
const totalClaimed = 0;
const totalUnclaimed = 0;
console.log(totalEarned.toFixed(2), "total earned", data);
let calls = contracts.length > 0 ? getCallsData(contracts) : [];
Copy link
Contributor

@akiraonstarknet akiraonstarknet Apr 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

u may have to filter claimed items from contracts arr? in zkLend too

@akiraonstarknet akiraonstarknet merged commit 499f8e3 into strkfarm:claims May 6, 2024
1 check failed
akiraonstarknet added a commit that referenced this pull request Jul 30, 2024
@akiraonstarknet @ooochoche
@allcontributors @EjembiEmmanuel @fishonamos
Fix Ekubo APRs, Add max deposit to consider fee (#17)
efbf3a4 
* feat: configure husky (#78)

* feat: configure husky

* test husky

* test husky

* feat: configure husky

* refac: add more scripts

* docs: add ooochoche as a contributor for infra (#82)

* docs: update README.md

* docs: update .all-contributorsrc

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* docs: add Jemiiah as a contributor for code (#83)

* docs: update README.md

* docs: update .all-contributorsrc

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* fix: fix ekubo base apr (#77)

* fix: fix STRK/USDC base apr

* fix: fix ekubo base aprs

* fix: fix ekubo base aprs

* feat: configure husky (#78)

* feat: configure husky

* test husky

* test husky

* feat: configure husky

* refac: add more scripts

* docs: add ooochoche as a contributor for infra (#82)

* docs: update README.md

* docs: update .all-contributorsrc

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* docs: add Jemiiah as a contributor for code (#83)

* docs: update README.md

* docs: update .all-contributorsrc

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* feat: add ekubo defi incentives

* feat: add ekubo defi incentives

* fix: fix ekubo base aprs

* feat: add ekubo defi incentives

---------

Co-authored-by: Benedict Ejembi <101812348+ooochoche@users.noreply.github.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* fix transaction revert on max deposit (#86)

* fix Transaction revert on max deposit

* fixes

* fmt

* fix

---------

Co-authored-by: Benedict Ejembi <101812348+ooochoche@users.noreply.github.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Oche <ejembioche50@gmail.com>
Co-authored-by: Fishon Amos <43862685+fishonamos@users.noreply.github.com>
akiraonstarknet added a commit that referenced this pull request Jul 30, 2024
@akiraonstarknet @VenkatTeja
@ooochoche @allcontributors @EjembiEmmanuel @fishonamos
Fix Ekubo APRs, Add max deposit to consider f (#18)
d88f5d6 
* Activate USDC DNMM

* Update STRK Sensei limit (#14)

Co-authored-by: Venkat Kunisetty <teja.kunisetty@gmail.com>

* add slinks

* do lint

* fix metadata

* do lint

* update slinks url

* connect data to slinks comp

* add USDC Sensei to prod, plus redirections

* Fix Ekubo APRs, Add max deposit to consider fee (#17)

* feat: configure husky (#78)

* feat: configure husky

* test husky

* test husky

* feat: configure husky

* refac: add more scripts

* docs: add ooochoche as a contributor for infra (#82)

* docs: update README.md

* docs: update .all-contributorsrc

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* docs: add Jemiiah as a contributor for code (#83)

* docs: update README.md

* docs: update .all-contributorsrc

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* fix: fix ekubo base apr (#77)

* fix: fix STRK/USDC base apr

* fix: fix ekubo base aprs

* fix: fix ekubo base aprs

* feat: configure husky (#78)

* feat: configure husky

* test husky

* test husky

* feat: configure husky

* refac: add more scripts

* docs: add ooochoche as a contributor for infra (#82)

* docs: update README.md

* docs: update .all-contributorsrc

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* docs: add Jemiiah as a contributor for code (#83)

* docs: update README.md

* docs: update .all-contributorsrc

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* feat: add ekubo defi incentives

* feat: add ekubo defi incentives

* fix: fix ekubo base aprs

* feat: add ekubo defi incentives

---------

Co-authored-by: Benedict Ejembi <101812348+ooochoche@users.noreply.github.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

* fix transaction revert on max deposit (#86)

* fix Transaction revert on max deposit

* fixes

* fmt

* fix

---------

Co-authored-by: Benedict Ejembi <101812348+ooochoche@users.noreply.github.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Oche <ejembioche50@gmail.com>
Co-authored-by: Fishon Amos <43862685+fishonamos@users.noreply.github.com>

---------

Co-authored-by: Venkat Kunisetty <teja.kunisetty@gmail.com>
Co-authored-by: Benedict Ejembi <101812348+ooochoche@users.noreply.github.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Oche <ejembioche50@gmail.com>
Co-authored-by: Fishon Amos <43862685+fishonamos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akiraonstarknet akiraonstarknet akiraonstarknet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zintarh @akiraonstarknet