Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the UI fix to the calculator #36

Merged
merged 5 commits into from
May 28, 2024

Conversation

jedstroke
Copy link

@jedstroke jedstroke commented May 27, 2024

Loom Video

PR Fixes:

  • Made all the Calculator UI fields reactive & added tooltips
  • Fixed the the x-axis tick issues

Resolves #3

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@akiraonstarknet akiraonstarknet changed the base branch from dev to il-calculator May 28, 2024 16:25
@akiraonstarknet akiraonstarknet merged commit 458123b into strkfarm:il-calculator May 28, 2024
1 check passed
@akiraonstarknet
Copy link
Contributor

akiraonstarknet commented May 28, 2024

Issues so far @jedstroke

  1. The second token is always ETH irrespective of what i select
  2. No logo shown on second token
  3. min price and max price do not invert on change token being denominated in. E.g. if min is 1500 STRK/ETH, should be 0.00066666 when other token is selected. Same logic as current price
  4. by default min price and max price to be +- 10% of current price
  5. Default current price formula is selected token price / other token price. Example if STRK price is $1.2 and ETH price is $3000, and we have ETH as base token selected in liquidity range, the price is ETHprice / STRK price and text is STRK per ETH. Similarly opposite if STRK is selected i.e. current price is STRK price / ETH price and text as ETH per STRK

Attaching loom https://www.loom.com/share/12f4158eeceb44ce87b8dff28e28f3f9?sid=bf151e82-0b7f-45f9-b739-8c05fc57d754

Feedback on calculations will be shared later.

@jedstroke jedstroke mentioned this pull request Jun 1, 2024
2 tasks
@akiraonstarknet
Copy link
Contributor

@all-contributors please add @jedstroke for code

Copy link
Contributor

@akiraonstarknet

I've put up a pull request to add @jedstroke! 🎉

akiraonstarknet added a commit to Ayoazeez26/starkfarm-client that referenced this pull request Sep 4, 2024
add APY % in Share on X msg, add CORS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concentrated liquidity impermanent loss calculator
2 participants