Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Fix/bb 2137 rename event listener #36

Merged
merged 4 commits into from
Apr 25, 2022
Merged

Fix/bb 2137 rename event listener #36

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8ab63f8
v1.0.1
evaschmuhl Apr 22, 2022
5202435
BB-2137 rename events to new player events
evaschmuhl Apr 22, 2022
735ea12
BB-2137 remove log
evaschmuhl Apr 25, 2022
568b00e
BB-2137 change version
evaschmuhl Apr 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cypress/static/ui.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,14 @@
video.addEventListener('contentVideoEnded', function() {
console.log('contentVideoEnded')
})
video.addEventListener('contentVideoFirstQuartile', function() {
console.log('contentVideoFirstQuartile')
video.addEventListener('contentVideoSecondOctile', function() {
console.log('contentVideoSecondOctile')
})
video.addEventListener('contentVideoMidpoint', function() {
console.log('contentVideoMidpoint')
})
video.addEventListener('contentVideoThirdQuartile', function() {
console.log('contentVideoThirdQuartile')
video.addEventListener('contentVideoSixthOctile', function() {
console.log('contentVideoSixthOctile')
})
StroeerVideoplayer.setDefaultUIName('default')
const myvideoplayer = new StroeerVideoplayer(video);
Expand Down
8 changes: 4 additions & 4 deletions dev/dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,16 @@ video.addEventListener('contentVideoEnded', function () {
console.log('contentVideoEnded')
})

video.addEventListener('contentVideoFirstQuartile', function () {
console.log('contentVideoFirstQuartile')
video.addEventListener('contentVideoSecondOctile', function () {
console.log('contentVideoSecondOctile')
})

video.addEventListener('contentVideoMidpoint', function () {
console.log('contentVideoMidpoint')
})

video.addEventListener('contentVideoThirdQuartile', function () {
console.log('contentVideoThirdQuartile')
video.addEventListener('contentVideoSixthOctile', function () {
console.log('contentVideoSixthOctile')
})

video.addEventListener('plugin-endcard:show', function () {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "0.13.1",
"version": "1.0.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 1.0.0 I think but it doesn't matter much, you can leave it like this :P

"name": "@stroeer/stroeer-videoplayer-plugin-endcard",
"description": "Ströer Videoplayer Endcard Plugin",
"main": "dist/stroeerVideoplayer-endcard-plugin.umd.js",
Expand Down
5 changes: 3 additions & 2 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,16 @@ const plugin = {
const videoEl = stroeervideoplayer.getVideoEl()
endcardPlugin = new EndcardPlugin(stroeervideoplayer, opts)

videoEl.addEventListener('contentVideoFirstQuartile', onVideoElFirstQuartile)
console.log('add second octile')
videoEl.addEventListener('contentVideoSecondOctile', onVideoElFirstQuartile)
videoEl.addEventListener('contentVideoEnded', onVideoElEnd)
},
deinit: (stroeervideoplayer: IStroeerVideoplayer) => {
const videoEl = stroeervideoplayer.getVideoEl()
const endcardContainer = stroeervideoplayer.getRootEl().querySelector('.plugin-endcard-container')

if (endcardContainer !== undefined) {
videoEl.removeEventListener('contentVideoFirstQuartile', onVideoElFirstQuartile)
videoEl.removeEventListener('contentVideoSecondOctile', onVideoElFirstQuartile)
videoEl.removeEventListener('contentVideoEnded', onVideoElEnd)
endcardPlugin.reset()
endcardContainer.remove()
Expand Down
Loading