Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

only have one interval and clear it when ticker is 0 #54

Merged
merged 2 commits into from
Aug 31, 2022

Conversation

evaschmuhl
Copy link
Collaborator

There was an error in Safari, when the endcard revolverplay was finished in an inactive tab and the new content video should start, the ticker callback was fired endlessly.
The interval was sometimes not cleared by clearInterval because of race conditions I guess.

Sandbox:
https://esc-3.sb.giga.de/news/e-scooter-fahren-zu-zweit-freihaendig-betrunken-was-ist-erlaubt/

Copy link
Collaborator

@jrsmb jrsmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense to me!

@evaschmuhl evaschmuhl merged commit b5ca8d1 into main Aug 31, 2022
@evaschmuhl evaschmuhl deleted the fix/BB-2137-fix-inactive-tabs-error-endcard branch August 31, 2022 06:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants