Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version bumps (protoc 3.18.0) #297

Merged
merged 7 commits into from
Sep 28, 2021
Merged

version bumps (protoc 3.18.0) #297

merged 7 commits into from
Sep 28, 2021

Conversation

harryherbig
Copy link
Contributor

@harryherbig harryherbig commented Sep 22, 2021

  • protoc 3.18.0
  • gh actions

had to manually override gradle dep (see protocolbuffers/protobuf#8985)

❗ Docker Image (3.18.0) is already pushed to ECR

- protoc 3.18.0
- gh actions
@bobaaaaa
Copy link
Contributor

we also need to bump the node dep. "google-protobuf": "3.17.3" to "google-protobuf": "3.18.0"

@bobaaaaa bobaaaaa added the ✋ do not merge Do not merge this Pull Request label Sep 22, 2021
@harryherbig
Copy link
Contributor Author

why "do not merge?" @bobaaaaa

@bobaaaaa bobaaaaa removed the ✋ do not merge Do not merge this Pull Request label Sep 22, 2021
Copy link
Contributor

@bobaaaaa bobaaaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node part looks good 👍

@bobaaaaa
Copy link
Contributor

why "do not merge?" @bobaaaaa

The missing node dep bump. Looks good now 👍

@moritzzimmer moritzzimmer merged commit c1ea762 into master Sep 28, 2021
@moritzzimmer moritzzimmer deleted the bumpy-bump branch September 28, 2021 06:31
@bobaaaaa bobaaaaa added this to the tapir 0.22.0 milestone Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants