Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node-legacy): initial setup + version bumps #323

Merged
merged 3 commits into from
Nov 17, 2021
Merged

feat(node-legacy): initial setup + version bumps #323

merged 3 commits into from
Nov 17, 2021

Conversation

bobaaaaa
Copy link
Contributor

@bobaaaaa bobaaaaa commented Nov 16, 2021 •
edited
Loading

What

  • node: bump to node16
  • node: bump all dependencies except google-protobuf
  • node-legacy: c&p all code
  • adding all configs to generate stubs for node-legacy

Info

I decided on the name node-legacy because it must hurt in your eyes.

Local published for testing: https://github.com/stroeer/tapir/packages/1099086

moritzzimmer
moritzzimmer requested changes Nov 16, 2021
View reviewed changes
Copy link
Member

@moritzzimmer moritzzimmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the generate target to support node-legacy as well

LANGUAGES := java node go node-legacy
.PHONY: generate java node go node-legacy
generate: $(LANGUAGES) ## Generates source files for all supported languages

@bobaaaaa bobaaaaa added the javascript Pull requests that update Javascript code label Nov 17, 2021
@bobaaaaa bobaaaaa merged commit 228a724 into master Nov 17, 2021
@bobaaaaa bobaaaaa deleted the feat(node)_add_node_legacy branch November 17, 2021 07:32
thisismana pushed a commit to thisismana/tapir that referenced this pull request Jan 11, 2022
@bobaaaaa @thisismana
feat(node-legacy): initial setup + version bumps (stroeer#323)
ed1b515 
* chore(node): bump all

* feat(node-legacy): initial setup

* update make file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moritzzimmer moritzzimmer moritzzimmer approved these changes

@harryherbig harryherbig Awaiting requested review from harryherbig

@thisismana thisismana Awaiting requested review from thisismana

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobaaaaa @moritzzimmer