-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added service for navigation rpc #505
Conversation
@@ -0,0 +1,28 @@ | |||
syntax = "proto3"; | |||
|
|||
package stroeer.navigation.v1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idea: use a new package instead of fragement
to make major versions bumps/dependencies easier in the future....
|
||
service NavigationService { | ||
// Retrieve navigation tree structure | ||
rpc GetNavigation(GetNavigationRequest) returns (GetNavigationResponse) {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rpc GetNavigation(google.protobuf.Empty) returns (GetNavigationResponse) {}
and then add a message later if required?
see https://cloud.google.com/java/docs/reference/protobuf/latest/com.google.protobuf.Empty and https://stackoverflow.com/a/51426142/12016
already been used in: core_article_service.proto
A generic empty message that you can re-use to avoid defining duplicated empty messages in your APIs. A typical example is to use it as the request or the response type of an API method. For instance: service Foo { rpc Bar(google.protobuf.Empty) returns (google.protobuf.Empty); } The JSON representation for Empty is empty JSON object {}.
76f7a39
to
17fc4bc
Compare
what
why
align navigation data in our products
example