Skip to content

Allow Request Cancelation #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Allow Request Cancelation #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5d8c35
Update services.template.ejs
hellsan631 Jun 1, 2018
f8cc721
add test for cancelRequest on generated properties
hellsan631 Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/services.template.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ if (typeof module !== 'undefined' && typeof exports !== 'undefined' &&
<% } -%>
url: urlBase + <%- helpers.quotedString(helpers.getPropertyOfFirstEndpoint(action, 'fullPath')) %>,
method: <%- helpers.quotedString(helpers.getPropertyOfFirstEndpoint(action, 'verb')) %>,
cancellable: true,
},
<% }); // meta.methods.foreach -%>
<% if (meta.isUser) { -%>
Expand Down
13 changes: 13 additions & 0 deletions test.e2e/spec/services.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,19 @@ define(['angular', 'given', 'util'], function(angular, given, util) {
);
return list.$promise;
});

it('has a $cancelRequest property', function() {
var list = MyModel.find(
function() {

Copy link
Member

@bajtos bajtos Jun 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this empty line.

var list = MyModel.find
  function() {},
  util.throwHttpError
);

},
util.throwHttpError
);

expect(list).to.have.own.property('$cancelRequest');

return list.$promise;
});

it('can create new resource', function() {
var obj = MyModel.create({ name: 'new' }, function() {
Expand Down