-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEMVER-MAJOR] Enhance how Swagger is mapped to LoopBack implementation #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a quick review only, because I am not very familiar with this part of the code base. The changes look good to me, although the test coverage could be better.
Please remove the .npmignore
file per my comment and squash the commits before merging.
.npmignore
Outdated
test | ||
.travis.yml | ||
test | ||
.travis.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be committed to git, it's auto-generated by slt-release
from .gitignore
. Please remove the file from version control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please squash commits before landing.
Use tags to create public LoopBack models Introduce x-implementation-templates and x-implementation Map definitions to private LoopBack models Consider base path
9125a4b
to
6fd978d
Compare
Description
The PR enhances Swagger to LoopBack code generation as follows:
tags
to group operations into LoopBack models that hosts remote methodsThe changes are made to support common banking api project which maps IBM industry models to LoopBack baked banking APIs.
Related issues
Checklist
guide