Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEMVER-MAJOR] Enhance how Swagger is mapped to LoopBack implementation #81

Merged
merged 3 commits into from
Feb 1, 2017

Conversation

raymondfeng
Copy link
Member

@raymondfeng raymondfeng commented Jan 19, 2017

Description

The PR enhances Swagger to LoopBack code generation as follows:

  • Use tags to group operations into LoopBack models that hosts remote methods
  • Generate private LoopBack models from Swagger definitions
  • Introduce x-operation-name, x-implementation-templates, x-implementation-template properties to customize code generation.

The changes are made to support common banking api project which maps IBM industry models to LoopBack baked banking APIs.

Related issues

  • None

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick review only, because I am not very familiar with this part of the code base. The changes look good to me, although the test coverage could be better.

Please remove the .npmignore file per my comment and squash the commits before merging.

.npmignore Outdated
test
.travis.yml
test
.travis.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be committed to git, it's auto-generated by slt-release from .gitignore. Please remove the file from version control.

Copy link
Contributor

@gunjpan gunjpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash commits before landing.

Raymond Feng added 3 commits February 1, 2017 14:39
Use tags to create public LoopBack models
Introduce x-implementation-templates and x-implementation
Map definitions to private LoopBack models
Consider base path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants