Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] strict mode cleanup #1299

Closed
3 tasks
bajtos opened this issue Apr 14, 2015 · 3 comments
Closed
3 tasks

[3.0] strict mode cleanup #1299

bajtos opened this issue Apr 14, 2015 · 3 comments

Comments

@bajtos
Copy link
Member

bajtos commented Apr 14, 2015

I am proposing to make a following change in 3.0:

  • strict is not defined or is false - dynamic properties are supported (no change from 2.0)
  • strict is true - dynamic properties are stripped and a validation error is reported (same as strict: 'validate' in 2.0)
  • The other two modes from 2.0 (strict: true silently discarding values and strict: 'throw') should be removed.

@ritch @raymondfeng @fabien @clarkorz thoughts?

Tasks:

@bajtos bajtos changed the title [3.0] [3.0] strict mode cleanup Apr 14, 2015
@bajtos bajtos added this to the #Epic: LoopBack 3.0 milestone Apr 14, 2015
@bajtos bajtos self-assigned this Apr 14, 2015
@clark0x
Copy link
Contributor

clark0x commented Apr 14, 2015

Does strict: true strip dynamic properties for schemaless datasource like mongodb?

Currently, strict does not affect for this kinds of data source.

@bajtos
Copy link
Member Author

bajtos commented Apr 14, 2015

AFAIK, strict: true strips dynamic properties for all datasources, including mongodb. Note that the default value is connector-specific and defaults to false. SQL connectors set the value to true by default.

@ritch ritch closed this as completed Apr 14, 2015
@ritch ritch reopened this Apr 14, 2015
@bajtos bajtos added #plan and removed #tob labels May 12, 2016
@bajtos bajtos assigned 0candy and unassigned bajtos May 12, 2016
@bajtos bajtos added #sprint10 and removed #plan labels May 17, 2016
@bajtos bajtos added #tob and removed #plan labels May 26, 2016
@bajtos bajtos assigned gunjpan and unassigned 0candy May 26, 2016
@bajtos bajtos added #plan and removed #tob labels May 26, 2016
@bajtos bajtos removed the tob-4-weeks label Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants