Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default Model.settings.updateOnLoad #2417

Closed
3 tasks
Amir-61 opened this issue Jun 9, 2016 · 0 comments
Closed
3 tasks

Change default Model.settings.updateOnLoad #2417

Amir-61 opened this issue Jun 9, 2016 · 0 comments
Assignees
@Amir-61
Labels
breaking-change stale
Milestone
#Epic: Compat Fla...

Comments

@Amir-61
Copy link
Contributor

Amir-61 commented Jun 9, 2016 •
edited
Loading

Model.settings.updateOnLoad

Change default of Model.settings.updateOnLoad to true
https://github.com/strongloop/loopback-datasource-juggler/blob/5dca27278a37b1e2e0fa572c3ae20681cd500680/lib/dao.js#L2551-L2557

  • Change Model.settings.updateOnLoad default to true
  • CI test passes (remove test case / confirm new implementation or replacement has tests)
  • Update 3.0-RELEASE-NOTES.md indicating breaking change

See https://docs.strongloop.com/display/LB/Model+definition+JSON+file
Possibly related : #1299
@Amir-61 Amir-61 added this to the #Epic: Compat Flags Cleanup milestone Jun 9, 2016
@Amir-61 Amir-61 self-assigned this Jun 9, 2016
@Amir-61 Amir-61 changed the title Change default Model.settings.updateOnLoad Change default Model.settings.updateOnLoad to true Jun 9, 2016
@Amir-61 Amir-61 changed the title Change default Model.settings.updateOnLoad to true Change default Model.settings.updateOnLoad Jun 9, 2016
@bajtos bajtos added #tob and removed #plan labels Jun 24, 2016
@Amir-61 Amir-61 added #plan and removed #tob labels Aug 4, 2016
@bajtos bajtos added #tob and removed #plan labels Aug 17, 2016
@Amir-61 Amir-61 added #wip and removed #sprint17 labels Aug 26, 2016
@Amir-61 Amir-61 mentioned this issue Aug 29, 2016
Closed
@bajtos bajtos added #plan and removed #wip labels Sep 6, 2016
@Amir-61 Amir-61 closed this as completed Sep 14, 2016
@Amir-61 Amir-61 removed the #plan label Sep 14, 2016
@Amir-61 Amir-61 assigned Amir-61 and unassigned Amir-61 Sep 16, 2016
@Amir-61 Amir-61 reopened this Sep 16, 2016
@Amir-61 Amir-61 added #wip and removed #wip labels Sep 16, 2016
@Amir-61 Amir-61 removed the #tob label Sep 29, 2016
@stale stale bot added the stale label Aug 23, 2017
@stale stale bot closed this as completed Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Amir-61 Amir-61

Labels
breaking-change stale
Projects
None yet
Milestone
#Epic: Compat Flags Cleanup
Development

No branches or pull requests
2 participants
@bajtos @Amir-61