Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hidden properties #217

Merged
merged 3 commits into from
Mar 31, 2014
Merged

Feature/hidden properties #217

merged 3 commits into from
Mar 31, 2014

Conversation

ritch
Copy link
Member

@ritch ritch commented Mar 21, 2014

Adds a new feature "hidden properties". Fixes #160

/to @raymondfeng

@slnode
Copy link

slnode commented Mar 21, 2014

All is well
Refer to this link for build results: http://ci.strongloop.com/job/loopback/1029/

@raymondfeng
Copy link
Member

The code looks good. I wonder if we should promote/generalize it into the modeling part of loopback-datasource-juggler. Here are some use cases:

  1. To prevent properties from being serialized into JSON responses for remote calls (This is probably a remoting concern. Should it part of the model definition or remoting metadata?)
  2. To prevent properties from being persisted into backend stores (derived/transient properties)
  3. To prevent properties from being modified (readonly?)

@ritch
Copy link
Member Author

ritch commented Mar 24, 2014

I wonder if we should promote/generalize it into the modeling part of loopback-datasource-juggler

I think this makes a lot of sense. Probably should wait for 2.0.

@raymondfeng
Copy link
Member

LGTM for 1.x.

@raymondfeng
Copy link
Member

Maybe add a comment to the code to say 'experimental'?

@ritch
Copy link
Member Author

ritch commented Mar 27, 2014

Maybe add a comment to the code to say 'experimental'?

Added.

@slnode
Copy link

slnode commented Mar 27, 2014

All is well
Refer to this link for build results: http://ci.strongloop.com/job/loopback/1042/

ritch added a commit that referenced this pull request Mar 31, 2014
@ritch ritch merged commit 5f81fad into master Mar 31, 2014
@bajtos bajtos deleted the feature/hidden-properties branch October 14, 2014 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST: User response includes hashed password
3 participants