Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to nan 2.0.x #51

Merged
merged 2 commits into from
Sep 25, 2015
Merged

Upgrade to nan 2.0.x #51

merged 2 commits into from
Sep 25, 2015

Conversation

raymondfeng
Copy link
Member

@bnoordhuis
Copy link
Member

The ubuntu-0.10 buildbot is failing with what looks like memory corruption:

*** Error in `node': free(): invalid size: 0x00007f38840292d0 ***
Aborted (core dumped)

(EDIT: And what seems to be a NULL pointer deref in Connection::CreateV8ObjectFromRow().)

The Windows build is failing with what looks like a missing #include <time.h>:

..\src\connection.cpp(904): error C2228: left of '.ToLocalChecked' must have class/struct/union [D:\workspace\strong-oracle.pr\cd6b86e3\build\oracle_bindings.vcxproj]
..\src\connection.cpp(904): error C3861: 'time': identifier not found [D:\workspace\strong-oracle.pr\cd6b86e3\build\oracle_bindings.vcxproj]
..\src\connection.cpp(920): error C2228: left of '.ToLocalChecked' must have class/struct/union [D:\workspace\strong-oracle.pr\cd6b86e3\build\oracle_bindings.vcxproj]
..\src\connection.cpp(920): error C3861: 'time': identifier not found [D:\workspace\strong-oracle.pr\cd6b86e3\build\oracle_bindings.vcxproj]

@raymondfeng
Copy link
Member Author

@bnoordhuis I fixed the time issue.

Can you help troubleshoot http://ci.strongloop.com/job/strong-oracle.pr/18/label=amazon-0.10/console? It seems that the crash is caused by GC of buffer.

@raymondfeng
Copy link
Member Author

test please

1 similar comment
@raymondfeng
Copy link
Member Author

test please

@bnoordhuis
Copy link
Member

It's possible that nodejs/node#2912 fixes the GC crash.

@ChALkeR
Copy link

ChALkeR commented Sep 16, 2015

Adding to the list: nodejs/node#2798.

raymondfeng added a commit that referenced this pull request Sep 25, 2015
@raymondfeng raymondfeng merged commit bffa1fe into master Sep 25, 2015
@raymondfeng raymondfeng deleted the feature/nan-2.x branch September 25, 2015 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants