Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote Connector Does not call execHooks on invoke #150

Closed
BerkeleyTrue opened this issue Dec 26, 2014 · 2 comments
Closed

Remote Connector Does not call execHooks on invoke #150

BerkeleyTrue opened this issue Dec 26, 2014 · 2 comments

Comments

@BerkeleyTrue
Copy link
Contributor

Is there a specific reason why the RestAdapter.prototype.invoke method does not call execHooks?

I am extending loopback-connector-remote to hook into user.login/logout and these do not get called due to the above.

I would be glad to submit a PR if there is not specific reason.
@BerkeleyTrue BerkeleyTrue mentioned this issue Dec 28, 2014
Merged
@bajtos
Copy link
Member

bajtos commented Jan 13, 2015

@BerkeleyTrue is this fixed now that #152 was landed?

@BerkeleyTrue
Copy link
Contributor Author

@bajtos Yes. Closing.

raymondfeng pushed a commit that referenced this issue Jan 15, 2015
Merge tag 'v2.11.1'
544aa8b 
2.11.1

 * Optimize the code to remove closure and bind (Raymond Feng)

 * Fix parsing JSON arrays with arrayItemDelimiters on. (Samuel Reed)

 * Add remote hooks to RestAdapter.invoke method Hooks on invoke are needed to use methods like User.login remotely from loopback-connector-remote. see #150 and #105 and strongloop/loopback#943 (Berkeley Martinez)

 * Ensure Remote-Connector Converts Types in Array Fix bug strongloop/loopback#886 (Berkeley Martinez)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bajtos @BerkeleyTrue