Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No relationship tag in implied relationships #174

Closed
ICEMANno1 opened this issue May 17, 2022 · 4 comments
Closed

No relationship tag in implied relationships #174

ICEMANno1 opened this issue May 17, 2022 · 4 comments

Comments

@ICEMANno1
Copy link

Hi Simon,
if I see it right, sometimes you create a relationship without the relationship tag (e.g. implied relationships)

@Nullable
Relationship addRelationship(Element source, @Nonnull Element destination, String description, String technology, boolean createImpliedRelationships) {
return addRelationship(source, destination, description, technology, null, new String[0], createImpliedRelationships);
}
@Nullable
Relationship addRelationship(Element source, @Nonnull Element destination, String description, String technology, InteractionStyle interactionStyle) {
return addRelationship(source, destination, description, technology, interactionStyle, new String[0], true);
}

Is there a reason? Does this harm any structurizr tooling logic?

I'm just wondering :)
Regards
Dominik

@simonbrowndotje
Copy link
Contributor

Correct, yes ... you can read more about this in issue 167.

@ICEMANno1
Copy link
Author

Ahh, k. Seems like not effect anymore. Even cli seems to work, not like the comment in the issue states. Or Amy I mistaking and the cli shouldn't work yet?

@simonbrowndotje
Copy link
Contributor

Yes, all of the Structurizr tooling was modified to take this change into account.

@ICEMANno1
Copy link
Author

Great 👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants