Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParentCell title longer than its width fixed #71

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ParentCell title longer than its width fixed #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11e12e1
ParentCell title longer than its width fixed
moarsoarse May 31, 2024
d50df7e
Merge branch 'structurizr:main' into contribution
moarsoarse Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions src/js/structurizr-diagram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3685,7 +3685,9 @@ structurizr.ui.Diagram = function(id, diagramIsEditable, constructionCompleteCal
padding = { top: 20, right: 20, bottom: 50, left: 20 };
}

let metaDataWidth=0;
if (metadataText && metadataText.length > 0) {
metaDataWidth = calculateWidth(metadataText, fontSize);
padding.bottom = padding.bottom + fontSize + fontSize + metaDataFontSizeDifference;
} else {
padding.bottom = padding.bottom + fontSize;
Expand Down Expand Up @@ -3718,17 +3720,30 @@ structurizr.ui.Diagram = function(id, diagramIsEditable, constructionCompleteCal
bottom: padding.bottom,
left: padding.left
};

//find the width of title, i.e. icon+name/metadata
const iconWidth = parentCell._computedStyle.icon ? parentCell.attr('.structurizrIcon')['width'] : 0;
const nameWidth = calculateWidth(parentCell.attr('.structurizrName').text,fontSize);
const titleWidth = Math.max(nameWidth, metaDataWidth) + iconWidth;
const childrenWidth = maxX - minX;

let newWidth=padding.left + padding.right;
if (titleWidth > childrenWidth) {
//position so that children are centered
newWidth += titleWidth;
minX = minX - (titleWidth - childrenWidth)/2
} else {
newWidth+= childrenWidth;
}

var newWidth = maxX - minX + padding.left + padding.right;
var newHeight = maxY - minY + padding.top + padding.bottom;
var newX = minX - padding.left;
var newY = minY - padding.top;

var margin = 15;
var refX = (margin / newWidth);

if (parentCell._computedStyle.icon !== undefined) {
var iconWidth = parentCell.attr('.structurizrIcon')['width'];

if (iconWidth > 0) {
var iconHeight = parentCell.attr('.structurizrIcon')['height'];
parentCell.attr({
'.structurizrIcon': {
Expand Down