-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add state "ignored" #85
Comments
I like not having to change a status we already use 😁 We can provide a skipped reason already as well (skipped due to disabled mutator, skipped due to file exclusion, skipped due to method exclusion) |
I like it! Stryker4s already has the possibility to filter out mutant categories. Though working them into the report might be a bit of refactoring. Initially I thought 'Disabled' might make sense too, but Ignored is probably better as it doesn't imply user action (filtered out duplicate mutants could be Ignored, for example). |
@Mobrockers you can still use |
I don't think duplicate mutants should be included in the report at all. When would there be a duplicate mutant? Creating a duplicate mutant should be avoided at all. It also doesn't fit with @nicojs 's reasoning for the name change, which is to clarify that the status |
I'd prefer to call it I'd also prefer to have a reason why the mutant was ignored. |
I'm working on adding this |
Our mutants already have a |
Adds the MutantStatus `Ignored`. This state should be used whenever a user has chosen to ignore mutants. These mutants are not counted in the score. They are added to the total number of generated mutants. Fixes #85 Co-authored-by: Hugo van Rijswijk <hugo.v.rijswijk@gmail.com> Co-authored-by: Nico Jansen <jansennico@gmail.com>
Both Stryker.NET as Stryker have (or will have) ways to ignore certain mutations (either by mutator name or other means). We want ignored mutations to also be visible in the mutation score. We should add this as a mutator state.
See stryker-mutator/stryker-js#1472
@Mobrockers what should the name be? I would prefer
Ignored
as it is really clear that the user choose to ignore it. Something likeskipped
could have any reason.The text was updated successfully, but these errors were encountered: