Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for .mjs and .cjs file formats #2343

Closed
nicojs opened this issue Aug 1, 2020 · 5 comments
Closed

Add support for .mjs and .cjs file formats #2343

nicojs opened this issue Aug 1, 2020 · 5 comments
Labels
🐛 Bug Something isn't working
Milestone
4.0

Comments

@nicojs
Copy link
Member

nicojs commented Aug 1, 2020

The new instrumenter determins the file types based on the extension. We're missing support for .cjs and .mjs file types.
@nicojs nicojs added the 🐛 Bug Something isn't working label Aug 1, 2020
@nicojs nicojs added this to the 4.0 milestone Aug 1, 2020
@bartekleon
Copy link
Member

bartekleon commented Aug 1, 2020 •
edited
Loading

what are those CJS files? commonJS files? 🤔
normal javascript mutator should be able to use mjs files tho 🤔

@nicojs
Copy link
Member Author

nicojs commented Aug 3, 2020

Yeah, just needs to be added here: https://www.github.com/stryker-mutator/stryker/tree/epic%2Fmutation-switching/packages%2Finstrumenter%2Fsrc%2Fparsers%2Findex.ts

@nicojs
Copy link
Member Author

nicojs commented Aug 4, 2020

More info on these extensions can be found here: https://nodejs.org/api/esm.html

A great read IMHO

@Omhet
Copy link
Contributor

Omhet commented Aug 17, 2020

Hi @nicojs

That sounds like not much work to do. Can I try to work on this?

@nicojs
Copy link
Member Author

nicojs commented Aug 17, 2020

Sure! Thanks in advance!

Omhet added a commit to Omhet/stryker that referenced this issue Aug 18, 2020
@Omhet
fix(parser): add support for mjs files (stryker-mutator#2343)
b9bfda3
Omhet added a commit to Omhet/stryker that referenced this issue Aug 18, 2020
@Omhet
fix(parser): add support for cjs files (stryker-mutator#2343)
6203aba
@Omhet Omhet mentioned this issue Aug 18, 2020
Merged
@nicojs nicojs closed this as completed Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Something isn't working
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
3 participants
@nicojs @bartekleon @Omhet