Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typescript and vue files to default mutate array #2384

Closed
nicojs opened this issue Aug 14, 2020 · 0 comments · Fixed by #2452
Closed

Add typescript and vue files to default mutate array #2384

nicojs opened this issue Aug 14, 2020 · 0 comments · Fixed by #2452
Labels
🚀 Feature request New feature request
Milestone
4.0

Comments

@nicojs
Copy link
Member

nicojs commented Aug 14, 2020

Since we now support JS, TS and Vue files by default (since mutation switching), we should reflect all file types in the default mutate array:

[
        "{src,lib}/**/*.js?(x)",
        "!{src,lib}/**/__tests__/**/*.js?(x)",
        "!{src,lib}/**/?(*.)+(spec|test).js?(x)",
        "!{src,lib}/**/*+(Spec|Test).js?(x)"
]

Maybe clean it up a little bit as well, with current knowledge of globbing strategies :)
@nicojs nicojs added the 🚀 Feature request New feature request label Aug 14, 2020
@nicojs nicojs added this to the 4.0 milestone Aug 14, 2020
@nicojs nicojs changed the title Add typescript and vuew files to default mutate array Add typescript and vue files to default mutate array Aug 18, 2020
@nicojs nicojs mentioned this issue Sep 2, 2020
Merged
nicojs added a commit that referenced this issue Sep 3, 2020
@nicojs
feat(mutate): a new default for mutate (#2452)
673516d 
Change the default patterns for which files should be mutated to:

```json
{ 
  "mutate": [
    "{src,lib}/**/!(*.+(s|S)pec|*.+(t|T)est).+(cjs|mjs|js|ts|jsx|tsx|html|vue)", 
    "!{src,lib}/**/__tests__/**/*.+(cjs|mjs|js|ts|jsx|tsx|html|vue)"
  ]
}
```

Basically means any JS or friend file in the `lib` or `src` directory that isn't obviously a test file.

Fixes #2384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚀 Feature request New feature request
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

feat(mutate): a more sane default for mutate stryker-mutator/stryker-js
1 participant
@nicojs