-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phantomjs processes are not killed correctly on error #251
Comments
@Bobvdb thanks for reporting this issue! The versions you print are taken from your package.json file, correct? Could you please provide information on the actually installed versions? ( I might have found the, if your are indeed using v0.3.3 of Could you please install the latest versions of all dependencies? |
Below you can find the list of installed packages with their version. As you can see we are indeed using stryker-karma-runner 0.3.3. I'll update it and see if the problem still occurs than. |
I updated all the libraries but the problem is still there. Below the output of the
|
@nicojs The information off the debug session:
|
@Lepetere also has this issue, he created a small project which recreates this issue on linux. I forked it here https://github.com/nicojs/UnitTestCourse. Thanks @Lepetere! I just had a major breakthrough. We kill child test runner processes with |
We'll ship this (hopefully soon) in the next major release |
This has been released with Stryker |
Thanks for getting this fixed guys! |
We noticed all resources on our server were used up by phantom phantomjs processes (how ironic ;)). When investigating, we found at that stryker doesn't always kill the phantomjs process. It doesn't kill it properly when we see the following error
The error can happen multiple times per run. Most of the time it will go wrong in an exponential fashion. In the beginning it fails one, then it fails a little bit more often and in the end all tests will fail with this error all the time. '
I think this is a raise condition because only a few runs have this trouble, not all runs.
Versions:
"grunt-stryker": "^0.1.0",
"stryker": "^0.5.6",
"stryker-api": "^0.4.2",
"stryker-html-reporter": "^0.3.0",
"stryker-jasmine": "^0.1.0",
"stryker-karma-runner": "^0.3.3",
The text was updated successfully, but these errors were encountered: