Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IsolatedTestRunnerAdapter): Don't kill processes using SIGKILL #270

Merged
merged 1 commit into from
Apr 7, 2017
Merged

fix(IsolatedTestRunnerAdapter): Don't kill processes using SIGKILL #270

merged 1 commit into from
Apr 7, 2017

Conversation

simondel
Copy link
Member

@simondel simondel commented Apr 7, 2017

Fixes #251

@simondel simondel requested a review from nicojs April 7, 2017 15:13
nicojs
nicojs approved these changes Apr 7, 2017
View reviewed changes
Copy link
Member

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@simondel simondel merged commit f606e9d into master Apr 7, 2017
@simondel simondel deleted the sigkill branch April 7, 2017 16:40
@simondel simondel restored the sigkill branch April 9, 2017 18:21
@simondel simondel deleted the sigkill branch April 9, 2017 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicojs nicojs nicojs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simondel @nicojs