Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glob 11 doesn't support node 18 #4930

Closed
romainmenke opened this issue Aug 2, 2024 · 5 comments · Fixed by #4935
Closed

glob 11 doesn't support node 18 #4930

romainmenke opened this issue Aug 2, 2024 · 5 comments · Fixed by #4935
Labels
🐛 Bug Something isn't working

Comments

@romainmenke
Copy link

This change was introduced in: #4894

Resulting in:

npm error code EBADENGINE
npm error engine Unsupported engine
npm error engine Not compatible with your version of node/npm: glob@11.0.0
npm error notsup Not compatible with your version of node/npm: glob@11.0.0
npm error notsup Required: {"node":"20 || >=22"}
npm error notsup Actual:   {"npm":"10.7.0","node":"v18.20.4"}

While stryker itself still claims to support node 18:

"node": ">=18.0.0"

Would it be possible to revert the glob update?

@romainmenke romainmenke added the 🐛 Bug Something isn't working label Aug 2, 2024
@nicojs
Copy link
Member

nicojs commented Aug 6, 2024

Thanks for reporting. Will fix asap

@nicojs
Copy link
Member

nicojs commented Aug 6, 2024

F.y.i. found this issue with an explanation on why the latest major release of glob and others don't support node 18 anymore. isaacs/node-lru-cache#343

@romainmenke
Copy link
Author

Yup, I have no strong opinion on any of that :)
I slightly prefer keeping support for node 18 around a bit longer, but these are short term pains.

I am also fine with bumping the minimum node version in stryker and doing a semver major.
Stryker is a dev tool and can assume to be used mostly on more recent node versions.

The only real issue is that stryker advertises node 18 support, while having a dependency that requires a higher version.

@nicojs
Copy link
Member

nicojs commented Aug 6, 2024

Stryker is a dev tool and can assume to be used mostly on more recent node versions.

I've worked on big enterprise projects where developers couldn't choose to upgrade, requiring weeks of work. I like the clarity of the NodeJS release schedule.

@romainmenke
Copy link
Author

Thank you @nicojs for the speedy updates here 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants