-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added colors to file names and line+col numbers in clear-text reporter #1185
Added colors to file names and line+col numbers in clear-text reporter #1185
Conversation
Same cyan & yellow as I added to TypeScript. It seems to work well there. Starts on 975 (fancy emojis can come next!)
|
Hmm looks better I think. I'll have a look at the tests. @simondel what do you think? It removes the names of the tests that ran, but do we really need them? It's a nice feature, but it also takes up a lot of space. Maybe we can have 1 sentence:
EDIT: Apparently it is configurable now? Very cool, let me check it out first :) |
I also wonder if we really need the |
It is a lot of repeated text. It would be awesome if could at a remark in front of the mutator:
I would just remove the |
If you don't mind, I think we could also remove the Edit: Just re-read and realized I'd misinterpreted your last comment, nicojs. I can make that change if you'd like! Will wait for input. |
RIP Mutant Survived! |
This is actually useful info. If you want to disable a mutator, you need to know the name. |
I'm thinking of adding a global option for |
That sounds nice... though what if we want to have one reporter in color and another without? Would the I'll update this PR for the |
What would that use case be? The only reason I see for disabling the colors is for build servers. |
@JoshuaKGoldberg I've created a separate issue for it. Could you explain it further there? #1218 |
Same cyan & yellow as TypeScript. It seems to work well there. Removes the extra lines of output as an opt-out behavior to make output more concise.
Starts on #975 (fancy emojis can come next!)
Before:
After: