Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Jest integration test): Improve quality of jest integration test #1260

Merged
merged 2 commits into from
Nov 29, 2018

Conversation

nicojs
Copy link
Member

@nicojs nicojs commented Nov 29, 2018

Improve quality of jest integration test. Before now, we only had 1 test without assertions running as integration. It is better than nothing, but far from ideal.

I now grabbed some tests from reactstrap. I think this will help build confidence when improving the jest runner.

@ghost ghost assigned nicojs Nov 29, 2018
@ghost ghost added the 🔎 Needs review label Nov 29, 2018
@nicojs nicojs changed the title test(jest): Improve quality of jest integration test test(Jest integration test): Improve quality of jest integration test Nov 29, 2018
Copy link
Member

@simondel simondel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Merge when green

@nicojs nicojs merged commit ed72e2d into master Nov 29, 2018
@ghost ghost removed the 🔎 Needs review label Nov 29, 2018
@nicojs nicojs deleted the test/improve-jest-integration-test branch November 29, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants