fix mutation of Array constructor call for TypeScript

[brodycj]

with testing

resolves #1902

[bartekleon]

Looks good at first glance, but I think there might be a small mistake or a way to make this code shorter:

} else if (node.kind === ts.SyntaxKind.CallExpression) {
      if (node.expression.kind === ts.SyntaxKind.Identifier && node.expression.getFullText(sourceFile).trim() === 'Array') {
        if (node.arguments && node.arguments.length) {
          return [{ node, replacement: 'Array()' }];
        } else {
          return [{ node, replacement: 'Array([])' }];
        }
      } else {
        return [];
      }
    } else {
      if (node.expression.getFullText(sourceFile).trim() === 'Array') {
        if (node.arguments && node.arguments.length) {
          return [{ node, replacement: 'new Array()' }];
        } else {
          return [{ node, replacement: 'new Array([])' }];
        }
      } else {
        return [];
      }
    }

This part looks fishy / strange. Especially that you are calling node.expression.getFullText(sourceFile).trim() === 'Array' in two places

[brodycj]

I pushed some changes to make the code shorter, and add another test case to hopefully ensure we do not make another mistake. I hope this is good to go soon, it is now blocking updates needed on PR #1898.

[bartekleon]

Now it looks much cleaner :D

[bartekleon]

@nicojs, @simondel if you could take a look / merge it :)