Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exclude mutations (inProgress) #1912

Closed
wants to merge 1 commit into from
Closed

feat: exclude mutations (inProgress) #1912

wants to merge 1 commit into from

Conversation

bartekleon
Copy link
Member

fixes: #1472
closes: #1810

@brodycj
Copy link

brodycj commented Dec 4, 2019

FYI I think there would be a conflict between the updates in this PR so far and some of the JavaScript mutator improvements in PR #1898. I wonder if we should consider breaking the functionality of JavaScriptMutator.mutate() a little more smartly in PR #1898, or revisit some time later.

@bartekleon
Copy link
Member Author

Well, we can always see later :/

For now, I think we should focus on this PR though since this feature is commonly required by people :/

What's left to do is:

  • add an exclusion for a specific mutation in javascript mutator
  • add these features to vue mutator

Things which should be done soon:

  • improve reporters so these mutations will be called "excluded" or sth like this.

@simondel
Copy link
Member

We want to introduce a parser API to support an easy and safe way to make the exclusions. This issue will lay the groundwork for it: #1893. Before this is done, we will not support this option.

We will keep your work here in mind as a reference ♥

@simondel simondel closed this Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore specific mutations
3 participants