fix(concurrency): better default for low CPU count #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets the default `--concurrency` to CPU count when the number of available CPU's <= 4. Also updates the docs (appearently, `--concurrency` was missing from the readme).
|
@Lakitna , you might also have an opinion on this? Feel free to pitch in |
Lakitna
reviewed
Oct 9, 2020
| @@ -237,7 +237,7 @@ | |||
| "default": [] | |||
| }, | |||
| "concurrency": { | |||
| "description": "Set the concurrency of workers. Stryker will always run checkers and test runners in parallel by creating worker processes (note, not `worker_threads`). This defaults to n-1 where n is the number of cpu's available on your machine. This is a sane default for most use cases.", | |||
| "description": "Set the concurrency of workers. Stryker will always run checkers and test runners in parallel by creating worker processes (note, not `worker_threads`). This defaults to n-1 where n is the number of cpu's available on your machine, unless CPU count is <= 4, in that case it uses the CPU count. This is a sane default for most use cases.", | |||
There was a problem hiding this comment.
the number of cpu's available
'number of CPU threads' would be more accurate. Calling them 'cores' or 'logical cores' works too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the default
--concurrencyto CPU count when the number of available CPU's <= 4.Also updates the docs (apparently,
--concurrencywas missing from the readme).Fixes #2542