Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(karma runner): restart a browser on disconnect error #3020

Merged
merged 17 commits into from
Jul 29, 2021
Merged

fix(karma runner): restart a browser on disconnect error #3020

merged 17 commits into from
Jul 29, 2021

Conversation

nicojs
Copy link
Member

@nicojs nicojs commented Jul 23, 2021 •
edited
Loading

  • Restart a browser when it disconnects. This allows us to recover from an infinite loop (as long as the timeout allows for it).
  • Refactor the karma runner to allow restarting of the browser
  • Refactor to no longer pass raw options to karma.runner.run
  • Implement dispose in the karma runner. It now closes the browser karma server. Useful during integration testing.

Fixes #2989
Fixes #2847

@nicojs nicojs force-pushed the fix/retry-on-empty-result branch from ac516a7 to d01b092 Compare July 26, 2021 20:28
@nicojs nicojs changed the title fix(test runner): retry a mutant when no tests were executed fix(karma runner): restart a browser on disconnect error Jul 28, 2021
@nicojs nicojs merged commit fc5c449 into master Jul 29, 2021
@nicojs nicojs deleted the fix/retry-on-empty-result branch July 29, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mutation scores differ on same file when run with other files karma-runner: stop using raw cli options
1 participant
@nicojs